Migrate ILDPerformance to KEY4HEP#45
Conversation
|
Please note that until the previous PR is merged, this branch also includes formatting updates for Python and Markdown files, as well as the update to the current ILCSOFT version |
|
Can you please make your changes such that one can run either the old (Marlin/LCIO) way or the new Key4hep (Gaudi/EDM4hep) ? This way one can also cross check the two against each other. As far as I can tell, right now there is a mic where some stuff (sinhle muons) are run in key4hep and others like ttbar is run with Marlin... |
25b7598 to
bad055b
Compare
Using this PR, you can run the new Key4hep version, and to run the older version, simply switch to the previous commit. This is the easiest way to run the program in both versions |
This is because I have only used the single muon version so far. I thought of translating the ttbar version in a later PR |
b3be189 to
86b1f8d
Compare
353d015 to
a0de922
Compare
15df90c to
8c81a29
Compare
|
Can the same results be reproduced exactly? In principle it should be possible, they are running the same chain with the same parameters and same seed right? |
|
I'm not aware of anything that would prevent an exact replication |
|
It would be good to reproduce exactly. A single event could be enough. If you find out something has changed, you won't be able to disentangle from other changes elsewhere or this change unless everything is validated before and after. |
BEGINRELEASENOTES
Marlin MarlinStdReco.xmlwithk4run ILDReconstruction.py.gitignorefile to the repositoryENDRELEASENOTES