Skip to content

Migrate ILDPerformance to KEY4HEP#45

Open
Victor-Schwan wants to merge 7 commits into
iLCSoft:masterfrom
Victor-Schwan:to-k4hep
Open

Migrate ILDPerformance to KEY4HEP#45
Victor-Schwan wants to merge 7 commits into
iLCSoft:masterfrom
Victor-Schwan:to-k4hep

Conversation

@Victor-Schwan

@Victor-Schwan Victor-Schwan commented May 7, 2026

Copy link
Copy Markdown
Contributor

BEGINRELEASENOTES

  • Migrated ILD reconstruction steering from ILCSOFT to Key4HEP, replacing Marlin MarlinStdReco.xml with k4run ILDReconstruction.py
  • Added a .gitignore file to the repository

ENDRELEASENOTES

@Victor-Schwan

Copy link
Copy Markdown
Contributor Author

Please note that until the previous PR is merged, this branch also includes formatting updates for Python and Markdown files, as well as the update to the current ILCSOFT version

@gaede

gaede commented May 13, 2026

Copy link
Copy Markdown
Contributor

Can you please make your changes such that one can run either the old (Marlin/LCIO) way or the new Key4hep (Gaudi/EDM4hep) ? This way one can also cross check the two against each other. As far as I can tell, right now there is a mic where some stuff (sinhle muons) are run in key4hep and others like ttbar is run with Marlin...

@Victor-Schwan Victor-Schwan force-pushed the to-k4hep branch 2 times, most recently from 25b7598 to bad055b Compare May 13, 2026 13:38
@Victor-Schwan

Copy link
Copy Markdown
Contributor Author

Can you please make your changes such that one can run either the old (Marlin/LCIO) way or the new Key4hep (Gaudi/EDM4hep) ? This way one can also cross check the two against each other.

Using this PR, you can run the new Key4hep version, and to run the older version, simply switch to the previous commit. This is the easiest way to run the program in both versions

@Victor-Schwan

Copy link
Copy Markdown
Contributor Author

As far as I can tell, right now there is a mic where some stuff (sinhle muons) are run in key4hep and others like ttbar is run with Marlin...

This is because I have only used the single muon version so far. I thought of translating the ttbar version in a later PR

@Victor-Schwan

Copy link
Copy Markdown
Contributor Author

Merge #46 and #47 first

@Victor-Schwan Victor-Schwan force-pushed the to-k4hep branch 3 times, most recently from 353d015 to a0de922 Compare May 29, 2026 14:44
@Victor-Schwan

Copy link
Copy Markdown
Contributor Author

Merge #48 and #49 first

@Victor-Schwan Victor-Schwan force-pushed the to-k4hep branch 2 times, most recently from 15df90c to 8c81a29 Compare June 1, 2026 18:43
@jmcarcell

Copy link
Copy Markdown
Contributor

Can the same results be reproduced exactly? In principle it should be possible, they are running the same chain with the same parameters and same seed right?

@Victor-Schwan

Copy link
Copy Markdown
Contributor Author

I'm not aware of anything that would prevent an exact replication

@jmcarcell

jmcarcell commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

It would be good to reproduce exactly. A single event could be enough. If you find out something has changed, you won't be able to disentangle from other changes elsewhere or this change unless everything is validated before and after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants